Re: [PATCH] efifb: Check efifb_pci_dev before using it

From: Sudeep Holla
Date: Thu Apr 22 2021 - 06:41:26 EST


On Wed, Apr 14, 2021 at 8:20 AM Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
>
> On Tue, Apr 13, 2021 at 2:37 PM Daniel Vetter <daniel@xxxxxxxx> wrote:
> >
> > On Tue, Apr 13, 2021 at 8:02 PM Alex Deucher <alexdeucher@xxxxxxxxx> wrote:
> > >
> > > On Tue, Apr 13, 2021 at 1:05 PM Kai-Heng Feng
> > > <kai.heng.feng@xxxxxxxxxxxxx> wrote:
> > > >
> > > > On some platforms like Hyper-V and RPi4 with UEFI firmware, efifb is not
> > > > a PCI device.
> > > >
> > > > So make sure efifb_pci_dev is found before using it.
> > > >
> > > > Fixes: a6c0fd3d5a8b ("efifb: Ensure graphics device for efifb stays at PCI D0")
> > > > BugLink: https://bugs.launchpad.net/bugs/1922403
> > > > Signed-off-by: Kai-Heng Feng <kai.heng.feng@xxxxxxxxxxxxx>
> > >
> > > Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
> >
> > fbdev is in drm-misc, so maybe you can push this one too?
>
> Yes, pushed. Thanks!
>

Can we have this pushed into the branch that gets merged into linux-next.
I still don't see this fix in -next and we are unable to do testing on our
platform as we hit a boot crash without this as reported in [1]. We prefer
running tests on -next without any additional patches or reverts, hence
the nagging, sorry for that.

Regards,
Sudeep

[1] https://lore.kernel.org/dri-devel/20210415102224.2764054-1-sudeep.holla@xxxxxxx/