Re: [PATCH] nvmem: qfprom: minor nit fixes, no functional change

From: Rajendra Nayak
Date: Mon Apr 26 2021 - 00:19:07 EST

On 4/23/2021 8:34 PM, Doug Anderson wrote:

On Fri, Apr 23, 2021 at 12:05 AM Rajendra Nayak <rnayak@xxxxxxxxxxxxxx> wrote:

Fix a missed newline, and update a comment which is stale
after the merge of '5a1bea2a: nvmem: qfprom: Add support for fuse
blowing on sc7280'
No other functional change in this patch.

Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
Sending a follow-up patch for these nits since they came in after
the previous patch was already pulled in

drivers/nvmem/qfprom.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index d6d3f24..b7d2060 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -122,6 +122,7 @@ static const struct qfprom_soc_compatible_data sc7280_qfprom = {
.keepout = sc7280_qfprom_keepout,
.nkeepout = ARRAY_SIZE(sc7280_qfprom_keepout)
* qfprom_disable_fuse_blowing() - Undo enabling of fuse blowing.
* @priv: Our driver data.
@@ -195,7 +196,7 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,

- * Hardware requires 1.8V min for fuse blowing; this may be
+ * Hardware requires a min voltage for fuse blowing; this may be
* a rail shared do don't specify a max--regulator constraints
* will handle.

Thanks for sending these! Is there a reason you didn't do the "else
if" change too?

Oops, sorry, looks like i didn't scroll all the way down.
Sending a v2 shortly.

QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation