Re: [PATCH][next] io_uring: Fix uninitialized variable up.resv

[Pavel Begunkov]

On 4/26/21 10:47 AM, Colin King wrote:
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> 
> The variable up.resv is not initialized and is being checking for a
> non-zero value in the call to _io_register_rsrc_update. Fix this by
> explicitly setting the pointer to 0.

LGTM, thanks Colin


> Addresses-Coverity: ("Uninitialized scalar variable)"
> Fixes: c3bdad027183 ("io_uring: add generic rsrc update with tags")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>
> ---
>  fs/io_uring.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/fs/io_uring.c b/fs/io_uring.c
> index f4ec092c23f4..63f610ee274b 100644
> --- a/fs/io_uring.c
> +++ b/fs/io_uring.c
> @@ -5842,6 +5842,7 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags)
>  	up.data = req->rsrc_update.arg;
>  	up.nr = 0;
>  	up.tags = 0;
> +	up.resv = 0;
>  
>  	mutex_lock(&ctx->uring_lock);
>  	ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
> 

-- 
Pavel Begunkov