Re: [PATCH v6 1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S
From: Tianling Shen
Date: Mon Apr 26 2021 - 06:39:21 EST
On Mon, Apr 26, 2021 at 5:33 AM Pavel Machek <pavel@xxxxxx> wrote:
> > > Changes in v6:
> > > - Fixed format of LED nodes
> > >
> > > Changes in v5:
> > > - Dropped the empty PCIe node
> > > - Dropped useless `/delete-property/`
> > > - Renamed LED nodes
> > >
> > > [...]
> > Applied, thanks!
> > [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R4S
> > commit: 1003888415e83e15ddb63d1d96189b4f2c5f1d48
> > [2/2] rockchip: rk3399: Add support for FriendlyARM NanoPi R4S
> > commit: db792e9adbf85ffc9d6b0b060ac3c8e3148c8992
> Sorry for late review, but:
> + label = "red:sys";
> This should be red:power based on the discussion in earlier threads.
However based on the introduction from FriendlyELEC, this is not
the "power" lamp...
"LEDs: 1 x power LED and 3 x GPIO Controlled LED (SYS, LAN, WAN)"