Re: [PATCH v2 net-next 1/9] dt-bindings: net: dsa: dt bindings for microchip lan937x

From: Florian Fainelli
Date: Mon Apr 26 2021 - 12:04:56 EST


On 4/25/21 9:05 PM, Prasanna Vengateshan wrote:
>>> + port@4 {
>>> + reg = <4>;
>>> + phy-mode = "rgmii";
>>> + ethernet = <&ethernet>;
>>
>> You are missing 'ethernet' label.
> This is the cpu port and label is not used anywhere. i received this feedback in
> last patch version.

Your example of a CPU port node is valid here, we need an 'ethernet'
phandle to know this is a CPU port, otherwise it is just a regular
user-facing port.
--
Florian