Re: [PATCH] kbuild: replace LANG=C with LC_ALL=C

From: Matthieu Baerts
Date: Mon Apr 26 2021 - 15:30:28 EST


Hi,

Thank you for the patch!

On 24/04/2021 13:48, Masahiro Yamada wrote:
> LANG gives a weak default to each LC_* in case it is not explicitly
> defined. LC_ALL, if set, overrides all other LC_* variables.
>
> LANG < LC_CTYPE, LC_COLLATE, LC_MONETARY, LC_NUMERIC, ... < LC_ALL
>
> This is why documentation such as [1] suggests to set LC_ALL in build
> scripts to get the deterministic result.
>
> LANG=C is not strong enough to override LC_* that may be set by end
> users.
>
> [1]: https://reproducible-builds.org/docs/locales/
>
> Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> ---
>
> arch/powerpc/boot/wrapper | 2 +-
> scripts/nsdeps | 2 +-
> scripts/recordmcount.pl | 2 +-
> scripts/setlocalversion | 2 +-
> scripts/tags.sh | 2 +-
> tools/testing/selftests/net/mptcp/mptcp_connect.sh | 2 +-

Acked-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx> (mptcp)

Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net