Re: [PATCH] PCI/VPD: fix unused pci_vpd_set_size function warning

From: Geert Uytterhoeven
Date: Tue Apr 27 2021 - 06:32:51 EST

On Wed, Apr 21, 2021 at 8:56 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> The only user of this function is now in an #ifdef, causing
> a warning when that symbol is not defined:
> drivers/pci/vpd.c:289:13: error: 'pci_vpd_set_size' defined but not used [-Werror=unused-function]
> 289 | static void pci_vpd_set_size(struct pci_dev *dev, size_t len)
> Move the function into that #ifdef block.
> Fixes: f349223f076e ("PCI/VPD: Remove pci_set_vpd_size()")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>



Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds