Re: [PATCH 1/1] lib: devres: Add error information printing for __devm_ioremap_resource()

From: Vladimir Oltean
Date: Wed Apr 28 2021 - 10:31:39 EST


On Wed, Apr 28, 2021 at 02:32:03PM +0800, Zhen Lei wrote:
> Ensure that all error handling branches print error information. In this
> way, when this function fails, the upper-layer functions can directly
> return an error code without missing debugging information. Otherwise,
> the error message will be printed redundantly or missing.
>
> Fixes: 35bd8c07db2c ("devres: keep both device name and resource name in pretty name")
> Signed-off-by: Zhen Lei <thunder.leizhen@xxxxxxxxxx>
> ---

A Fixes: tag is probably a bit too drastic, but anyway:

Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>