Re: [PATCH 058/190] Revert "media: cx231xx: replace BUG_ON with recovery code"

[Pavel Machek]

Hi!

i2c.c
> index c6659253c6fb..f33b6a077d57 100644
> --- a/drivers/media/usb/cx231xx/cx231xx-i2c.c
> +++ b/drivers/media/usb/cx231xx/cx231xx-i2c.c
> @@ -515,8 +515,7 @@ int cx231xx_i2c_register(struct cx231xx_i2c *bus)
>  {
>  	struct cx231xx *dev = bus->dev;
>  
> -	if (!dev->cx231xx_send_usb_command)
> -		return -EINVAL;
> +	BUG_ON(!dev->cx231xx_send_usb_command);
>  
>  	bus->i2c_adap = cx231xx_adap_template;
>  	bus->i2c_adap.dev.parent = dev->dev;

No big deal either way, and this will only be hit during
development. Linus does not like BUGs, so I'd keep this.

Best regards,
							Pavel
-- 
http://www.livejournal.com/~pavelmachek

Attachment: signature.asc
Description: Digital signature