Re: [PATCH net-next v3 3/6] net: add generic selftest support
From: Andrew Lunn
Date: Fri Apr 30 2021 - 08:31:45 EST
> Thanks for your patch, which is now commit 3e1e58d64c3d0a67 ("net: add
> generic selftest support") upstream.
> > --- a/net/Kconfig
> > +++ b/net/Kconfig
> > @@ -429,6 +429,10 @@ config GRO_CELLS
> > config SOCK_VALIDATE_XMIT
> > bool
> > +config NET_SELFTESTS
> > + def_tristate PHYLIB
> Why does this default to enabled if PHYLIB=y?
> Usually we allow the user to make selftests modular, independent of the
> feature under test, but I may misunderstand the purpose of this test.
Maybe there is a misunderstanding here with 'selftest'. The name page
for ethtool(1) says:
Executes adapter selftest on the specified network device. Pos‐
sible test modes are:
Perform full set of tests, possibly interrupting normal op‐
eration during the tests,
online Perform limited set of tests, not interrupting normal opera‐
Perform full set of tests, as for offline, and additionally
an external-loopback test.
This feature has nothing to do with tools/testing/selftests. It
predates that by decades.