Re: [PATCH] iio: am2315: Make am2315_acpi_id depend on CONFIG_ACPI

[Andy Shevchenko]

On Tue, May 4, 2021 at 5:41 PM Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
> With CONFIG_ACPI=n and -Werror, 0-day reports:
>
> drivers/iio/humidity/am2315.c:259:36: error:
>         'am2315_acpi_id' defined but not used

...

> +#ifdef CONFIG_ACPI
>  static const struct acpi_device_id am2315_acpi_id[] = {
>         {"AOS2315", 0},

This is a fake ID according to the specification. Do we have any proof
that it's being used in the wild?
If no, I prefer to drop this ID section entirely.

If yes, needs a comment which device is using it (however it may be
out of the scope of this fix).

>         {}
>  };
> -
>  MODULE_DEVICE_TABLE(acpi, am2315_acpi_id);
> +#endif

-- 
With Best Regards,
Andy Shevchenko