Re: [EXTERNAL] Re: [PATCH] EDAC: update edac printk wrappers to use printk_ratelimited.

From: Borislav Petkov
Date: Wed May 05 2021 - 17:04:53 EST


On Wed, May 05, 2021 at 03:23:57PM -0500, Tyler Hicks wrote:
> Would it be any more acceptable to add an
> edac_mc_printk_ratelimited() macro, which uses printk_ratelimited(),
> and then call that new macro from edac_ce_error()?

You guys are way off here: the intent of EDAC drivers is to accurately
report errors for purposes of counting them and doing analysis on
that collected data as to whether components are going wrong - not to
ratelimit them as some nuisance output.

With breaking the EDAC reporting, you're barking up the wrong tree - if
you don't want to see those errors, do not load the drivers. It is that
simple.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette