Re: [PATCH 01/11] mmc: core: Drop open coding when preparing commands with busy signaling

From: Linus Walleij
Date: Thu May 06 2021 - 08:50:34 EST


On Tue, May 4, 2021 at 6:12 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:

> Similar code for validating the host->max_busy_timeout towards the current
> command's busy timeout, exists in mmc_do_erase(), mmc_sleep() and
> __mmc_switch(). Let's move the common code into a helper function.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>

This is a really nice refactoring in its own right.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij