Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

From: skakit
Date: Fri May 07 2021 - 05:46:52 EST

> > > +
> > > +required:
> > > + - compatible
> > > + - reg
> > > +
> > > +additionalProperties: true
> >
> > Instead of allowing arbitrary properties, only valid modes
> > should be allowed. So drop additionalProperties and do this
> > instead:
> >
> > allOf:
> > - $ref: reboot-mode.yaml#
> >
> > unevaluatedProperties: false
> >
> Okay.

I am not able to use 'allOf' to refer reboot-mode.yaml as some of the
properties do not match with reboot-mode.yaml properties. Can we use oneOf
like below?

- $ref: "reboot-mode.yaml#"
- $ref: "../../input/qcom,pm8941-pwrkey.yaml#"

That does not make sense.

The reference to reboot-mode.yaml is needed because it adds valid
mode properties, so that you can set unevaluatedProperties to false.
You need it at the root of the PON binding. They are not added to
the required list, so it's fine if not all of them are used. Also
there can (and usually is) more than one mode, so using oneOf is not

Okay, but I am getting errors like below during make dtbs_check.

pon@800: 'compatible', 'pwrkey', 'reg' do not match any of the
regexes: '^mode-.*$', 'pinctrl-[0-9]+'

Seems like I have to make 'additionalProperties' as true in reboot-mode.yaml
I have checked other yaml binding docs where allOf is used, and they have 'additionalProperties' as true in the file which is being referred. Please let me know if this is not correct way to do it.

As suggested I have added

- $ref: reboot-mode.yaml#

at the root of binding and also added unevaluatedProperties: false

Last but not least the pwrkey reference is needed to describe
specific nodes (resin, pwrkey) and should not appear at the root
of the PON binding.

Also, If I drop additionalProperties I am getting below error.

'additionalProperties' is a required property

You need to add 'unevaluatedProperties: false'. It is basically
the same as 'additionalProperties: false', but also accepts
properties from the referenced bindings.


-- Sebastian

Satya Priya