Re: [PATCH v2] sched/pelt: Keep UTIL_AVG_UNCHANGED flag in sync when calculating last_enqueued_diff

From: Vincent Donnefort
Date: Mon May 10 2021 - 05:28:02 EST


> > >
> > > static inline unsigned long task_util_est(struct task_struct *p)
> > > @@ -4002,7 +4002,7 @@ static inline void util_est_update(struct cfs_rq *cfs_rq,
> > > * Reset EWMA on utilization increases, the moving average is used only
> > > * to smooth utilization decreases.
> > > */
> >
> > Needs to be updated to add:
> >
> > last_enqueued_diff = ue.enqueued & ~UTIL_AVG_UNCHANGED;
>
> The flag had been cleared before, otherwise would return earlier, so
> there is no need to clear this flag again.

Indeed, my bad. All good then.

--
Vincent