Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition

From: Uwe Kleine-König
Date: Mon May 10 2021 - 15:43:24 EST


Hello Jiri,

On 3/8/21 5:16 PM, Jiri Kosina wrote:
On Mon, 8 Mar 2021, Srinivas Pandruvada wrote:

A remove callback is only ever called for a bound device. So there
is no
need to check for device or driver being NULL.

Srinivas, any objections to this patchset? The cleanups look good to
me.
Sorry, I missed this series.
No objection for taking these patches.

Thanks. Applied with your Acked-by:
If you disagree with that interpretation of your statement above, please
holler :)

I expected these patches to go in during the 5.13 merge window, but they didn't. I found your pull request for 5.13 (https://lore.kernel.org/lkml/nycvar.YFH.7.76.2104292151220.18270@xxxxxxxxxxxxx/) and they were not included there even though the patches were in next since at least next-20210310. Looking at

git log --oneline --cherry v5.13-rc1...dce6a0d56a7719efcad438f5c46a9d192fd36a89

(where dce.. was the tip of your for-next for next-20210506 (i.e. before 5.13-rc1 was cut)) and it seems there are quite a few more commits that didn't make it into your pull request.

What am I missing?

Best regards
Uwe

Attachment: OpenPGP_signature
Description: OpenPGP digital signature