Re: [PATCH v2] cgroup: inline cgroup_task_freeze()

From: Shakeel Butt
Date: Mon May 10 2021 - 18:03:46 EST


On Mon, May 10, 2021 at 2:40 PM Roman Gushchin <guro@xxxxxx> wrote:
>
> After the introduction of the cgroup.kill there is only one call site
> of cgroup_task_freeze() left: cgroup_exit(). cgroup_task_freeze() is
> currently taking rcu_read_lock() to read task's cgroup flags, but
> because it's always called with css_set_lock locked, the rcu protection
> is excessive.
>
> Simplify the code by inlining cgroup_task_freeze().
>
> v2: fix build
>
> Signed-off-by: Roman Gushchin <guro@xxxxxx>

Reviewed-by: Shakeel Butt <shakeelb@xxxxxxxxxx>