Re: [PATCH v1 2/4] kdb: Switch to use %ptTs
From: Andy Shevchenko
Date: Tue May 11 2021 - 03:14:32 EST
On Mon, May 10, 2021 at 05:05:46PM -0700, Doug Anderson wrote:
> On Mon, May 10, 2021 at 8:04 AM Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> > Use %ptTs instead of open-coded variant to print contents
> > of time64_t type in human readable form.
> > Cc: Jason Wessel <jason.wessel@xxxxxxxxxxxxx>
> > Cc: Daniel Thompson <daniel.thompson@xxxxxxxxxx>
> > Cc: kgdb-bugreport@xxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> > ---
> > kernel/debug/kdb/kdb_main.c | 9 +--------
> > 1 file changed, 1 insertion(+), 8 deletions(-)
> I kinda doubt anyone would really care if we just switched kdb to just
> the old "%ptT". Probably no machines are parsing this string.
Formally it's an ABI.
> ...but in any case, now that the nifty new format is there we might as
> well use it. Thus:
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
With Best Regards,