Re: [PATCH v2] mm/page-writeback: Update the comment of Dirty position control

From: Jan Kara
Date: Tue May 11 2021 - 06:45:50 EST


On Tue 11-05-21 18:36:06, Chi Wu wrote:
> As the value of pos_ratio_polynom() clamp between 0 and
> 2LL << RATELIMIT_CALC_SHIFT, the global control line should be
> consistent with it.
>
> Signed-off-by: Chi Wu <wuchi.zero@xxxxxxxxx>

Thanks! Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

Honza

> ---
> mm/page-writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index 0062d5c57d41..3882405dc051 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -845,7 +845,7 @@ static long long pos_ratio_polynom(unsigned long setpoint,
> * ^ pos_ratio
> * |
> * | |<===== global dirty control scope ======>|
> - * 2.0 .............*
> + * 2.0 * * * * * * *
> * | .*
> * | . *
> * | . *
> --
> 2.17.1
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR