Re: [PATCH] MIPS: ralink: of: fix build of rt2880_wdt watchdog module

From: Guenter Roeck
Date: Fri May 14 2021 - 09:49:30 EST


On 5/14/21 6:17 AM, Krzysztof Kozlowski wrote:
When rt2880_wdt watchdog driver is built as a module, the
rt_sysc_membase needs to be exported (it is being used via inlined
rt_sysc_r32):

ERROR: modpost: "rt_sysc_membase" [drivers/watchdog/rt2880_wdt.ko] undefined!

Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>

Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>

I don't see a recent change in the code. Has that problem been there
all along ?

Thanks,
Guenter

---
arch/mips/ralink/of.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/mips/ralink/of.c b/arch/mips/ralink/of.c
index 0c5de07da097..b3ce706426c4 100644
--- a/arch/mips/ralink/of.c
+++ b/arch/mips/ralink/of.c
@@ -24,6 +24,8 @@
#include "common.h"
__iomem void *rt_sysc_membase;
+EXPORT_SYMBOL_GPL(rt_sysc_membase);
+
__iomem void *rt_memc_membase;
__iomem void *plat_of_remap_node(const char *node)