Re: [PATCH v2 4/9] x86/idt: remove address argument to idt_invalidate()

From: Andy Lutomirski
Date: Sat May 15 2021 - 11:28:57 EST


On 5/14/21 6:43 PM, H. Peter Anvin wrote:
> From: "H. Peter Anvin (Intel)" <hpa@xxxxxxxxx>
>
> There is no reason to specify any specific address to
> idt_invalidate(). It looks mostly like an artifact of unifying code
> done differently by accident. The most "sensible" address to set here
> is a NULL pointer - virtual address zero, just as a visual marker.
>
> This also makes it possible to mark the struct desc_ptr in
> idt_invalidate() as static const.
>
> Signed-off-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>

Acked-by: Andy Lutomirski <luto@xxxxxxxxxx>

> - idt_invalidate(phys_to_virt(0));
> + idt_invalidate();

This hunk is an actual change, but I'm not sure it needs to be mentioned
in the changelog.