Re: [PATCH v3 2/4] x86/syscall: update and extend selftest syscall_numbering_64

From: Ingo Molnar
Date: Sun May 16 2021 - 03:52:15 EST



* H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> From: "H. Peter Anvin (Intel)" <hpa@xxxxxxxxx>
>
> Update the syscall_numbering_64 selftest to reflect that a system call
> is to be extended from 32 bits. Add a mix of tests for valid and
> invalid system calls in 64-bit and x32 space.
>
> Use an explicit system call instruction, because we cannot know if the
> glibc syscall() wrapper intercepts instructions, extends the system
> call number independently, or anything similar.
>
> Use long long instead of long to make it possible to compile this test
> on x32 as well as 64 bits.
>
> Signed-off-by: H. Peter Anvin (Intel) <hpa@xxxxxxxxx>
> ---
> .../testing/selftests/x86/syscall_numbering.c | 274 ++++++++++++++----
> 1 file changed, 222 insertions(+), 52 deletions(-)

Small request: I'd suggest moving this to the first place - so that we can
easily test before/after effects of (current) patch #1/4.

Thanks,

Ingo