Re: [PATCH] scsi: target: tcmu: fix boolreturn.cocci warnings

From: Bodo Stroesser
Date: Sun May 16 2021 - 12:24:33 EST

On 16.05.21 01:03, kernel test robot wrote:
From: kernel test robot <lkp@xxxxxxxxx>

drivers/target/target_core_user.c:1424:9-10: WARNING: return of 0/1 in function 'tcmu_handle_completions' with return type bool

Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 9814b55cde05 ("scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found")
CC: Bodo Stroesser <bostroesser@xxxxxxxxx>
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: kernel test robot <lkp@xxxxxxxxx>

tree: master
head: c12a29ed9094b4b9cde8965c12850460b9a79d7c
commit: 9814b55cde0588b6d9bc496cee43f87316cbc6f1 scsi: target: tcmu: Return from tcmu_handle_completions() if cmd_id not found
:::::: branch date: 6 hours ago
:::::: commit date: 2 weeks ago

target_core_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1421,7 +1421,7 @@ static bool tcmu_handle_completions(stru
if (test_bit(TCMU_DEV_BIT_BROKEN, &udev->flags)) {
pr_err("ring broken, not handling completions\n");
- return 0;
+ return false;
mb = udev->mb_addr;

Acked-by: Bodo Stroesser <bostroesser@xxxxxxxxx>