[RFC PATCH 11/15] virtio-balloon: Handle virtio_device_ready() failure

From: Xie Yongji
Date: Mon May 17 2021 - 05:37:13 EST


Now virtio_device_ready() will return error if we get
invalid status. Let's handle this case in both probe
and resume paths.

Signed-off-by: Xie Yongji <xieyongji@xxxxxxxxxxxxx>
---
drivers/virtio/virtio_balloon.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 7565970c3901..4f183dd901b3 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -997,12 +997,17 @@ static int virtballoon_probe(struct virtio_device *vdev)
goto out_unregister_oom;
}

- virtio_device_ready(vdev);
+ err = virtio_device_ready(vdev);
+ if (err)
+ goto out_unregister_page_report;

if (towards_target(vb))
virtballoon_changed(vdev);
return 0;

+out_unregister_page_report:
+ if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_REPORTING))
+ page_reporting_unregister(&vb->pr_dev_info);
out_unregister_oom:
if (virtio_has_feature(vb->vdev, VIRTIO_BALLOON_F_DEFLATE_ON_OOM))
unregister_oom_notifier(&vb->oom_nb);
@@ -1096,7 +1101,11 @@ static int virtballoon_restore(struct virtio_device *vdev)
if (ret)
return ret;

- virtio_device_ready(vdev);
+ ret = virtio_device_ready(vdev);
+ if (ret) {
+ vdev->config->del_vqs(vdev);
+ return ret;
+ }

if (towards_target(vb))
virtballoon_changed(vdev);
--
2.11.0