Re: [PATCH v1 1/1] drm/i915: Include only needed headers in ascii85.h
From: Andy Shevchenko
Date: Mon May 17 2021 - 08:19:59 EST
On Wed, Apr 07, 2021 at 03:23:37PM +0300, Andy Shevchenko wrote:
> The ascii85.h is user of exactly two headers, i.e. math.h and types.h.
> There is no need to carry on entire kernel.h.
It seems DRM has strict rules about what's going thru DRM tree and this one,
while being used only for DRM drivers and been originated as i915 code, in a
stale position right now.
Who can take it, please? (It's Rb by Jani)
I Cc'ed this to Andrew, if he is okay to expedite it, and to Rob, who is the
committer of the original move patch.
Personally to me DRM seems the best match, but... see above.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> include/linux/ascii85.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/include/linux/ascii85.h b/include/linux/ascii85.h
> index 4cc40201273e..83ad775ad0aa 100644
> --- a/include/linux/ascii85.h
> +++ b/include/linux/ascii85.h
> @@ -8,7 +8,8 @@
> #ifndef _ASCII85_H_
> #define _ASCII85_H_
> -#include <linux/kernel.h>
> +#include <linux/math.h>
> +#include <linux/types.h>
> #define ASCII85_BUFSZ 6
With Best Regards,