Re: [PATCH 2/2] dt: bindings: lp55xx: Add predefined LED pattern

From: Doug Zobel
Date: Mon May 17 2021 - 16:08:50 EST


> Take a look at the pattern trigger. That's the way to change patterns
> at runtime, no need for firmware loading.

Thanks for the pointer. That looks like it could work. I would need
to add support for the lp5562 to run the patterns in hardware. The
only problem I see is in synchronizing the 3 color channels. Since
the pattern triggers are associated with each individual channel, I
don't see a clean way to run a multi-chanel (RGB) pattern and keep it
in sync. I was thinking I could restart all 3 channels' programs
anytime a channel program is changed. This would assure they start in
sync. However that would cause glitches in the patterns if they are
being used as 3 independent (non-RGB) patterns.

> I may even have compiler from that interface to the bytecode lp55xx
> uses. Some assembly will be required. Doing so with the RGB LED will
> be even more fun.

If you have some previous work on this, I could use it. Otherwise
I'll just write my own bytecode generator. As far as I know the
lp5562 is the only lp55xx controller which supports on chip
programming. So I would add the support in the lp5562 driver.

> We'll want to deprecate the firmware loading interface at some point.

If I add support for running the pattern triggers in lp5562 hardware,
then this will now be the 3rd method (firmware &
lp5562_run_predef_led_pattern() are the other two) for loading custom
patterns onto the chip. Will this be a problem?

-Doug