Re: [PATCH RESEND][next] hwmon: (max6621) Fix fall-through warnings for Clang

[Guenter Roeck]

On 5/17/21 5:45 PM, Gustavo A. R. Silva wrote:
> Hi Guenter,
>
> On 3/5/21 21:18, Guenter Roeck wrote:
> > On Fri, Mar 05, 2021 at 03:52:58AM -0600, Gustavo A. R. Silva wrote:
> > > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> > > by explicitly adding a break statement instead of letting the code fall
> > > through to the next case.
> > >
> > > Link: https://github.com/KSPP/linux/issues/115
> > > Acked-by: Guenter Roeck <linux@xxxxxxxxxxxx>
> > > Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>
> > > ---
> >
> > I Acked those, thus assuming that they would be applied through some
> > other tree. If that is not the case, you'll need to let me know. The
> > resend only means to me that whatever tree was supposed to pick it up
> > did not do it, but it doesn't result in any action from my side.
>
> If you don't mind, I'm taking this in my -next[1] branch for v5.14.

Ok with me for all.

Guenter

> Thanks
> --
> Gustavo
>
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
>
> > Guenter
> >
> > >   drivers/hwmon/max6621.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/hwmon/max6621.c b/drivers/hwmon/max6621.c
> > > index 367855d5edae..7821132e17fa 100644
> > > --- a/drivers/hwmon/max6621.c
> > > +++ b/drivers/hwmon/max6621.c
> > > @@ -156,7 +156,7 @@ max6621_is_visible(const void *data, enum hwmon_sensor_types type, u32 attr,
> > >   		default:
> > >   			break;
> > >   		}
> > > -
> > > +		break;
> > >   	default:
> > >   		break;
> > >   	}
> > > --
> > > 2.27.0