Re: [PATCH 3/3] clk: qcom: Add camera clock controller driver for SM8250

[Jonathan Marek]

On 5/18/21 7:42 AM, Robert Foss wrote:
> Hey Jonathan,
>
>
> > +static int cam_cc_sm8250_probe(struct platform_device *pdev)
> > +{
> > +       struct regmap *regmap;
> > +
> > +       regmap = qcom_cc_map(pdev, &cam_cc_sm8250_desc);
> > +       if (IS_ERR(regmap))
> > +               return PTR_ERR(regmap);
> > +
> > +       clk_lucid_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config);
> > +       clk_lucid_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config);
> > +       clk_lucid_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config);
> > +       clk_lucid_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config);
> > +
> > +       return qcom_cc_really_probe(pdev, &cam_cc_sm8250_desc, regmap);;
>
> Remove a semicolon.
>
> > +}
> > +
> > +static struct platform_driver cam_cc_sm8250_driver = {
> > +       .probe = cam_cc_sm8250_probe,
> > +       .driver = {
> > +               .name = "cam_cc-sm8250",
>
> Maybe conforming with the naming scheme of "sdm845-camcc" is the
> better way to go.

On the other hand there is cam_cc-sc7180. But it doesn't matter either 
way, I will change it.

> > +               .of_match_table = cam_cc_sm8250_match_table,
> > +       },
> > +};
> > +
> > +static int __init cam_cc_sm8250_init(void)
> > +{
> > +       return platform_driver_register(&cam_cc_sm8250_driver);
> > +}
> > +subsys_initcall(cam_cc_sm8250_init);
> > +
> > +static void __exit cam_cc_sm8250_exit(void)
> > +{
> > +       platform_driver_unregister(&cam_cc_sm8250_driver);
> > +}
> > +module_exit(cam_cc_sm8250_exit);
> > +
> > +MODULE_DESCRIPTION("QTI CAMCC SM8250 Driver");
> > +MODULE_LICENSE("GPL v2");
> > --
> > 2.26.1