答复: [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

[柏年福 (Nianfu Bai)]

> From: Nianfu Bai <nianfu.bai@xxxxxxxxxx>
>
> Tick broadcast installed by insmod cannot switch to oneshot mode
> correctly caused by linux timer framework, need to build in kernel
> image. SPRD_TIMER has been selected by SPRD arch, we have to enable
> SPRD arch when we build sprd timer in kernel image, this action
> conflicts with general kernel image, so we need to remove the dependency between sprd timer and SPRD arch.

This wording is a bit rough to parse.

All you really want to do is take away the fact that ARCH_SPRD is required here to turn this off, right?
>Yes, please refer to the following issues:
https://partnerissuetracker.corp.google.com/issues/176065415
https://android-review.googlesource.com/c/kernel/common/+/1549618


>
> Signed-off-by: Nianfu Bai <nianfu.bai@xxxxxxxxxx>
> Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@xxxxxxxxxx>
> ---
>  drivers/clocksource/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 39aa21d..04b333c 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -447,10 +447,8 @@ config MTK_TIMER
>    Support for Mediatek timer driver.
>
>  config SPRD_TIMER
> -bool "Spreadtrum timer driver" if EXPERT
> +bool "Spreadtrum timer driver" if COMPILE_TEST

No need for "if COMPILE_TEST" on this line.

>  depends on HAS_IOMEM
> -depends on (ARCH_SPRD || COMPILE_TEST)
> -default ARCH_SPRD

Just drop the ARCH_SPRD portion here and maybe make it depend on ARM64 instead like:
depends on (ARM64 || COMPILE_TEST)

>This module has nothing to do with the architecture, therefore it should not depend on ARM64.

and drop the EXPERT check above?

What is the goal of what you want to do here?  Just allow this to be enabled on whth type of systems?

-----邮件原件-----
发件人: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
发送时间: 2021年5月18日 17:05
收件人: Nianfu Bai <bnf20061983@xxxxxxxxx>
抄送: daniel.lezcano@xxxxxxxxxx; tglx@xxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; 柏年福 (Nianfu Bai) <nianfu.bai@xxxxxxxxxx>; 张瑞峰 (Ruifeng Zhang/10040) <Ruifeng.Zhang1@xxxxxxxxxx>
主题: Re: [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

On Tue, May 11, 2021 at 03:08:45PM +0800, Nianfu Bai wrote:
> From: Nianfu Bai <nianfu.bai@xxxxxxxxxx>
>
> Tick broadcast installed by insmod cannot switch to oneshot mode
> correctly caused by linux timer framework, need to build in kernel
> image. SPRD_TIMER has been selected by SPRD arch, we have to enable
> SPRD arch when we build sprd timer in kernel image, this action
> conflicts with general kernel image, so we need to remove the dependency between sprd timer and SPRD arch.

This wording is a bit rough to parse.

All you really want to do is take away the fact that ARCH_SPRD is required here to turn this off, right?

>
> Signed-off-by: Nianfu Bai <nianfu.bai@xxxxxxxxxx>
> Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@xxxxxxxxxx>
> ---
>  drivers/clocksource/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 39aa21d..04b333c 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -447,10 +447,8 @@ config MTK_TIMER
>    Support for Mediatek timer driver.
>
>  config SPRD_TIMER
> -bool "Spreadtrum timer driver" if EXPERT
> +bool "Spreadtrum timer driver" if COMPILE_TEST

No need for "if COMPILE_TEST" on this line.

>  depends on HAS_IOMEM
> -depends on (ARCH_SPRD || COMPILE_TEST)
> -default ARCH_SPRD

Just drop the ARCH_SPRD portion here and maybe make it depend on ARM64 instead like:
depends on (ARM64 || COMPILE_TEST)

and drop the EXPERT check above?

What is the goal of what you want to do here?  Just allow this to be enabled on what type of systems?

thanks,

greg k-h
________________________________
 This email (including its attachments) is intended only for the person or entity to which it is addressed and may contain information that is privileged, confidential or otherwise protected from disclosure. Unauthorized use, dissemination, distribution or copying of this email or the information herein or taking any action in reliance on the contents of this email or the information herein, by anyone other than the intended recipient, or an employee or agent responsible for delivering the message to the intended recipient, is strictly prohibited. If you are not the intended recipient, please do not read, copy, use or disclose any part of this e-mail to others. Please notify the sender immediately and permanently delete this e-mail and any attachments if you received it in error. Internet communications cannot be guaranteed to be timely, secure, error-free or virus-free. The sender does not accept liability for any errors or omissions.
本邮件及其附件具有保密性质，受法律保护不得泄露，仅发送给本邮件所指特定收件人。严禁非经授权使用、宣传、发布或复制本邮件或其内容。若非该特定收件人，请勿阅读、复制、 使用或披露本邮件的任何内容。若误收本邮件，请从系统中永久性删除本邮件及所有附件，并以回复邮件的方式即刻告知发件人。无法保证互联网通信及时、安全、无误或防毒。发件人对任何错漏均不承担责任。