Re: [PATCH 00/16] Rid W=1 warnings from Char

From: Arnd Bergmann
Date: Thu May 20 2021 - 08:59:18 EST


On Thu, May 20, 2021 at 2:13 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote:
>
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (16):
> char: pcmcia: cm4000_cs: Remove unused variable 'tmp'
> char: pcmcia: cm4040_cs: Remove unused variable 'uc'
> char: random: Include header containing our prototypes
> char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues
> char: pcmcia: synclink_cs: Fix a bunch of kernel-doc issues
> char: applicom: Remove 3 unused variables 'ret' and 2 instances of
> 'byte_reset_it'
> char: tpm: tpm1-cmd: Fix a couple of misnamed functions
> char: tpm: tpm_ftpm_tee: Fix a couple of kernel-doc misdemeanours
> char: agp: backend: Demote some non-conformant kernel-doc headers
> char: agp: frontend: Include header file containing our prototypes
> char: agp: via-agp: Remove unused variable 'current_size'
> char: hpet: Remove unused variable 'm'
> char: agp: generic: Place braces around optimised out function in if()
> char: agp: uninorth-agp: Remove unused variable 'size'
> char: hw_random: pseries-rng: Demote non-conformant kernel-doc header
> char: mem: Provide local prototype for non-static function

Thanks a lot!

I've looked all the patches now and commented on patches 6 and 16.
With my comments addressed

Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx>

Arnd