Re: [PATCH] genirq: Provide new interfaces for affinity hints

From: Thomas Gleixner
Date: Fri May 21 2021 - 17:45:20 EST


On Fri, May 21 2021 at 10:45, Lijun Pan wrote:
> On Fri, May 21, 2021 at 7:48 AM Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>> +/**
>> + * irq_update_affinity_hint - Update the affinity hint
>> + * @irq: Interrupt to update
>> + * @cpumask: cpumask pointer (NULL to clear the hint)
>> + *
>> + * Updates the affinity hint, but does not change the affinity of the interrupt.
>> + */
>> +static inline int
>> +irq_update_affinity_hint(unsigned int irq, const struct cpumask *m)
>> +{
>> + return __irq_apply_affinity_hint(irq, m, true);
>> +}
>
> Should it be:
> return __irq_apply_affinity_hint(irq, m, false);
> here?

Of course. Copy & Pasta should be forbidden.

Thanks for spotting it!

tglx