Re: [RFC net-next 2/2] net: fec: add ndo_select_queue to fix TX bandwidth fluctuations

From: Andrew Lunn
Date: Sun May 23 2021 - 10:46:22 EST


On Sun, May 23, 2021 at 06:20:19PM +0800, Joakim Zhang wrote:
> From: Fugang Duan <fugang.duan@xxxxxxx>
>
> As we know that AVB is enabled by default, and the ENET IP design is
> queue 0 for best effort, queue 1&2 for AVB Class A&B. Bandwidth of
> queue 1&2 set in driver is 50%, TX bandwidth fluctuated when selecting
> tx queues randomly with FEC_QUIRK_HAS_AVB quirk available.

How is the driver currently scheduling between these queues? Given the
802.1q priorities, i think we want queue 2 with the highest priority
for scheduling. Then queue 0 and lastly queue 1.

Andrew