Re: [PATCH v2] PCI: Check value of resource alignment before using __ffs

From: Amey Narkhede
Date: Mon May 24 2021 - 16:33:08 EST


On 21/04/22 01:57PM, Leon Romanovsky wrote:
> On Thu, Apr 22, 2021 at 04:25:38PM +0530, Amey Narkhede wrote:
> > Return value of __ffs is undefined if no set bit exists in
> > its argument. This indicates that the associated BAR has
> > invalid alignment.
> >
> > Signed-off-by: Amey Narkhede <ameynarkhede03@xxxxxxxxx>
> > ---
> > drivers/pci/setup-bus.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
>
> Thanks,
> Reviewed-by: Leon Romanovsky <leonro@xxxxxxxxxx>
A gentle ping :)