Re: [PATCH v2 1/2] reboot: Export reboot_mode
From: Bjorn Andersson
Date: Mon May 24 2021 - 23:32:57 EST
On Mon 24 May 07:09 CDT 2021, Lee Jones wrote:
> On Fri, 8 Nov 2019 at 23:41, Elliot Berman <eberman@xxxxxxxxxxxxxx> wrote:
> > Export reboot_mode to support kernel modules wishing to modify reboot_mode.
> > Signed-off-by: Elliot Berman <eberman@xxxxxxxxxxxxxx>
> > ---
> > kernel/reboot.c | 2 ++
> > 1 file changed, 2 insertions(+)
> Reviewed by Bjorn and GregKH, but never merged.
> I guess all the parties are still solving this downstream.
> Andrew, is this still something you'd consider?
Seems more reasonable that it would go together with patch 2, which
Sebastian pointed out doesn't build.
> diff --git a/kernel/reboot.c b/kernel/reboot.c
> > index c4d472b..b1fbc22 100644
> > --- a/kernel/reboot.c
> > +++ b/kernel/reboot.c
> > @@ -32,7 +32,9 @@ EXPORT_SYMBOL(cad_pid);
> > #define DEFAULT_REBOOT_MODE
> > #endif
> > enum reboot_mode reboot_mode DEFAULT_REBOOT_MODE;
> > +EXPORT_SYMBOL_GPL(reboot_mode);
> > enum reboot_mode panic_reboot_mode = REBOOT_UNDEFINED;
> > +EXPORT_SYMBOL_GPL(panic_reboot_mode);
> > /*
> > * This variable is used privately to keep track of whether or not
> > --
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> Lee Jones [?????????]
> Linaro Services Senior Technical Lead
> Linaro.org ??? Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog