Re: [PATCH v5 0/3] Add option to mmap GEM buffers cached

From: Thomas Zimmermann
Date: Tue May 25 2021 - 06:03:59 EST


Am 23.05.21 um 21:19 schrieb Paul Cercueil:
Hi Thomas,

Le dim., mai 23 2021 at 21:05:30 +0200, Thomas Zimmermann <tzimmermann@xxxxxxx> a écrit :

Am 23.05.21 um 19:04 schrieb Paul Cercueil:
V5 of my patchset which adds the option for having GEM buffers backed
non-coherent memory.

Changes from V4:

- [2/3]:
     - Rename to drm_fb_cma_sync_non_coherent
     - Invert loops for better cache locality
     - Only sync BOs that have the non-coherent flag
     - Properly sort includes
     - Move to drm_fb_cma_helper.c to avoid circular dependency

I'm pretty sure it's still not the right place. That would be something like drm_gem_cma_atomic_helper.c, but creating a new file just for a single function doesn't make sense.

drm_fb_cma_sync_non_coherent calls drm_fb_cma_* functions, so it's a better match than its former location (which wasn't good as it created a circular dependency between drm.ko and drm-kms-helper.ko).

Do you have a better idea?

No, it was more of a rant than a review comment. Please go ahead and merge the patchset.

Best regards

Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

Attachment: OpenPGP_signature
Description: OpenPGP digital signature