Re: [PATCH] iio: accel: fxls8962af: conditionally compile fxls8962af_i2c_raw_read_errata3()

From: Wolfram Sang
Date: Tue May 25 2021 - 16:31:15 EST



> > > The build is failing with this link error
> > > ld: fxls8962af-core.o: in function `fxls8962af_fifo_transfer':
> > > fxls8962af-core.c: undefined reference to `i2c_verify_client'
> > >
> > > This is needed for the i2c variant, not the spi variant. So
> > > conditionally compile based on CONFIG_FXLS8962AF_I2C.
> > >
> > Fixes: 68068fad0e1c ("iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads")
> > > Signed-off-by: Tom Rix <trix@xxxxxxxxxx>
> > Reviewed-by: Sean Nyekjaer <sean@xxxxxxxxxx>
>
> Given the purpose of that check is to verify it was an i2c_client
> should we be looking to instead provide a stub for the case where
> we don't have CONFIG_I2C?
>
> +CC Wolfram and linux-i2c list for input.

Such a stub sounds reasonable.

Attachment: signature.asc
Description: PGP signature