Re: [PATCH 18/43] KVM: x86: Consolidate APIC base RESET initialization code

From: Reiji Watanabe
Date: Wed May 26 2021 - 03:05:44 EST


On Fri, Apr 23, 2021 at 5:51 PM Sean Christopherson <seanjc@xxxxxxxxxx> wrote:
>
> Consolidate the APIC base RESET logic, which is currently spread out
> across both x86 and vendor code. For an in-kernel APIC, the vendor code
> is redundant. But for a userspace APIC, KVM relies on the vendor code
> to initialize vcpu->arch.apic_base. Hoist the vcpu->arch.apic_base
> initialization above the !apic check so that it applies to both flavors
> of APIC emulation, and delete the vendor code.
>
> Signed-off-by: Sean Christopherson <seanjc@xxxxxxxxxx>

Reviewed-by: Reiji Watanabe <reijiw@xxxxxxxxxx>