Re: [PATCH v10 00/18] virtio/vsock: introduce SOCK_SEQPACKET support

From: Arseny Krasnov
Date: Wed May 26 2021 - 08:16:15 EST



On 25.05.2021 17:52, Stefano Garzarella wrote:
> On Tue, May 25, 2021 at 11:22:09AM +0300, Arseny Krasnov wrote:
>> On 23.05.2021 15:14, Arseny Krasnov wrote:
>>> On 21.05.2021 10:55, Stefano Garzarella wrote:
>>>> Hi Arseny,
>>>>
>>>> On Thu, May 20, 2021 at 10:13:53PM +0300, Arseny Krasnov wrote:
>>>>> This patchset implements support of SOCK_SEQPACKET for virtio
>>>>> transport.
>>>> I'll carefully review and test this series next Monday, in the mean time
>>>> I think we should have at least an agreement about the changes that
>>>> regards virtio-spec before merge this series, to avoid any compatibility
>>>> issues.
>>>>
>>>> Do you plan to send a new version of the specification changes?
>>>>
>>>> Thanks,
>>>> Stefano
>>> Hello, sorry for long answer. I'm on vacation now, but i plan to send
>>>
>>> it in next several days, because with current implementation it is short
>>>
>>>
>>> Thank You
>> Hello, here is spec patch:
>>
>> https://lists.oasis-open.org/archives/virtio-comment/202105/msg00017.html
>>
>> Let's discuss it
> Yep, sure.
>
> About this series I think is better to split in two series since it
> became very long. Patchwork [1] also complains here [2].
>
> You can send a first series with patches from 1 to 7. These patches are
> reviewed by me and can go regardless of the discussion of the VIRTIO
> specifications.
Ok, i'll send it on next week.
> Maybe you can also add the patch with the test to this first series.
>
> Please specify in the cover letter that the implementation for virtio
> devices is under development and will be sent later.
>
>
> When it will be merged in the net-next tree, you can post the second
> part with the rest of the series that implements SEQPACKET for virtio
> devices, possibly after we received an agreement for the specifications.
>
> Please use the "net-next" tag and take a look at
> Documentation/networking/netdev-FAQ.rst about netdev development.
Ok
>
>
> Anyway, in the next days (hopefully tomorrow) I'll review the rest of
> the series related to virtio devices and spec.
>
> Thanks,
> Stefano
>
> [1]
> https://patchwork.kernel.org/project/netdevbpf/list/?series=486011&state=*
>
> [2]
> https://patchwork.kernel.org/project/netdevbpf/patch/20210520191449.1270723-1-arseny.krasnov@xxxxxxxxxxxxx/
>
>