Re: [PATCH] module: correctly exit module_kallsyms_on_each_symbol when fn() != 0

From: Jessica Yu
Date: Wed May 26 2021 - 08:58:48 EST


+++ Jon Mediero [20/05/21 14:23 +0200]:
Commit 013c1667cf78 ("kallsyms: refactor
{,module_}kallsyms_on_each_symbol") replaced the return inside the
nested loop with a break, changing the semantics of the function: the
break only exits the innermost loop, so the code continues iterating the
symbols of the next module instead of exiting.

Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
Signed-off-by: Jon Mediero <jmdr@xxxxxxxxxxx>

Good catch, thanks a lot for the fix! Applied to modules-next.

Jessica