Re: [External] [PATCH v2 1/4] slub: Restore slub_debug=- behavior
From: Muchun Song
Date: Wed May 26 2021 - 22:51:58 EST
On Thu, May 27, 2021 at 4:20 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> Quoting Vlastimil Babka (2021-05-26 03:39:54)
> > On 5/26/21 6:04 AM, Muchun Song wrote:
> > > On Wed, May 26, 2021 at 10:56 AM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote:
> > >>
> > >> Passing slub_debug=- on the kernel commandline is supposed to disable
> > >> slub debugging. This is especially useful with CONFIG_SLUB_DEBUG_ON
> > >> where the default is to have slub debugging enabled in the build. Due to
> > >> some code reorganization this behavior was dropped, but the code to make
> > >> it work mostly stuck around. Restore the previous behavior by disabling
> > >> the static key when we parse the commandline and see that we're trying
> > >> to disable slub debugging.
> > >>
> > >> Cc: Vlastimil Babka <vbabka@xxxxxxx>
> > >> Fixes: e17f1dfba37b ("mm, slub: extend slub_debug syntax for multiple blocks")
> > Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
> > >
> > > Is it caused by the commit ca0cab65ea2b ("mm, slub: introduce static
> > > key for slub_debug()")?
> > Yep, looks like a better Fixes: candidate.
> Fixed it. Thanks.
With that fix. Please feel free to add:
Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>