Re: [RESEND PATCH V1 2/5] PCI: tegra: Fix MSI-X programming

From: Krzysztof Wilczyński
Date: Thu May 27 2021 - 08:14:28 EST


Hi Prakash,

[...]
> @@ -1863,7 +1863,7 @@ static void pex_ep_event_pex_rst_deassert(struct tegra_pcie_dw *pcie)
> val = (ep->msi_mem_phys & MSIX_ADDR_MATCH_LOW_OFF_MASK);
> val |= MSIX_ADDR_MATCH_LOW_OFF_EN;
> dw_pcie_writel_dbi(pci, MSIX_ADDR_MATCH_LOW_OFF, val);
> - val = (lower_32_bits(ep->msi_mem_phys) & MSIX_ADDR_MATCH_HIGH_OFF_MASK);
> + val = (upper_32_bits(ep->msi_mem_phys) & MSIX_ADDR_MATCH_HIGH_OFF_MASK);

Oh! Nice catch!

Krzysztof