Re: [PATCH] sched/debug:fix stale comments of sched_debug

From: Andy Shevchenko
Date: Mon May 31 2021 - 03:48:48 EST


On Sun, May 30, 2021 at 10:51:45AM +0800, Hailong Liu wrote:
> From: Hailong Liu <liu.hailong6@xxxxxxxxxx>
>
> Now /proc/sched_debug has been moved to debugfs, so make the comments
> consistent with it.

Have you checked if the very same Kconfig option is used for something
slightly different as well?

> Signed-off-by: Hailong Liu <liu.hailong6@xxxxxxxxxx>

Missed SoB tag of the submitter.

...

> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1166,7 +1166,7 @@ config SCHED_DEBUG
> depends on DEBUG_KERNEL && PROC_FS

Are the dependencies correct?

> default y
> help
> - If you say Y here, the /proc/sched_debug file will be provided
> + If you say Y here, the debugfs/sched/debug file will be provided
> that can help debug the scheduler. The runtime overhead of this
> option is minimal.

--
With Best Regards,
Andy Shevchenko