Re: [PATCH v1 4/4] mm/mempolicy: kill MPOL_F_LOCAL bit
From: Feng Tang
Date: Mon May 31 2021 - 04:29:47 EST
On Mon, May 31, 2021 at 10:22:51AM +0200, Michal Hocko wrote:
> On Mon 31-05-21 15:32:52, Feng Tang wrote:
> > On Mon, May 31, 2021 at 09:00:25AM +0200, Michal Hocko wrote:
> > > I can see you have posted a newer version which I haven't seen yet but
> > > this is really better to get resolved before building up more on top.
> > > And let me be explicit. I do believe that rebinding preferred policy is
> > > just bogus and it should be dropped altogether on the ground that a
> > > preference is a mere hint from userspace where to start the allocation.
> > Yes, the current mpol_rebind_preferred()'s logic is confusing. Let me
> > try to understand it correctly, are you suggesting to do nothing for
> > 'prefer's rebinding regarding MPOL_F_STATIC_NODES and MPOL_F_RELATIVE_NODES,
> > while just setting 'pol->w.cpuset_mems_allowed' to the new nodemask?
> yes this is exactly what I've had in mind.
Thanks for confirming. Will spin another version.
> Michal Hocko
> SUSE Labs