Re: [PATCH 3/3] arm64: dts: mt8183: remove syscon from smi_common node

From: Enric Balletbo Serra
Date: Mon May 31 2021 - 17:39:51 EST


Hi Hsin-Yi,

(again without html, sorry for the noise)

Thank you for the patch.

Missatge de Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx> del dia dl., 31 de maig
2021 a les 6:36:
>
> We don't need to register smi_common as syscon. Also add required
> property power-domains for this node.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@xxxxxxxxxxxx>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>

> ---
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a..e074c0d402ff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1263,13 +1263,14 @@ larb0: larb@14017000 {
> };
>
> smi_common: smi@14019000 {
> - compatible = "mediatek,mt8183-smi-common", "syscon";
> + compatible = "mediatek,mt8183-smi-common";
> reg = <0 0x14019000 0 0x1000>;
> clocks = <&mmsys CLK_MM_SMI_COMMON>,
> <&mmsys CLK_MM_SMI_COMMON>,
> <&mmsys CLK_MM_GALS_COMM0>,
> <&mmsys CLK_MM_GALS_COMM1>;
> clock-names = "apb", "smi", "gals0", "gals1";
> + power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
> };
>
> imgsys: syscon@15020000 {
> --
> 2.32.0.rc0.204.g9fa02ecfa5-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-mediatek