Re: [PATCH next v1 1/2] dump_stack: move cpu lock to printk.c

From: kernel test robot
Date: Mon May 31 2021 - 17:50:50 EST

Hi John,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20210528]

base: 3e029760e6f8ce90c122c267a039ae73b3f1f5a4
config: x86_64-randconfig-a014-20210531 (attached as .config)
compiler: clang version 13.0.0 ( bc6799f2f79f0ae87e9f1ebf9d25ba799fbd25a9)
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git remote add linux-review
git fetch --no-tags linux-review John-Ogness/introduce-printk-cpu-lock/20210601-013122
git checkout 528abf3d0ab80471d02f4f16cbe97b2eaa918a11
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

lib/dump_stack.c:97: warning: Function parameter or member 'log_lvl' not described in 'dump_stack_lvl'
>> lib/dump_stack.c:97: warning: expecting prototype for dump_stack(). Prototype was for dump_stack_lvl() instead

vim +97 lib/dump_stack.c

^1da177e4c3f415 Linus Torvalds 2005-04-16 90
196779b9b4ce192 Tejun Heo 2013-04-30 91 /**
196779b9b4ce192 Tejun Heo 2013-04-30 92 * dump_stack - dump the current task information and its stack trace
196779b9b4ce192 Tejun Heo 2013-04-30 93 *
196779b9b4ce192 Tejun Heo 2013-04-30 94 * Architectures can override this implementation by implementing its own.
196779b9b4ce192 Tejun Heo 2013-04-30 95 */
d542aa86de8ad0c Alexander Potapenko 2021-05-26 96 asmlinkage __visible void dump_stack_lvl(const char *log_lvl)
^1da177e4c3f415 Linus Torvalds 2005-04-16 @97 {
528abf3d0ab8047 John Ogness 2021-05-31 98 unsigned int cpu_store;
d7ce36924344ace Eric Dumazet 2016-02-05 99 unsigned long flags;
b58d977432c80ee Alex Thorlton 2013-07-03 100
528abf3d0ab8047 John Ogness 2021-05-31 101 printk_cpu_lock(&cpu_store, &flags);
d542aa86de8ad0c Alexander Potapenko 2021-05-26 102 __dump_stack(log_lvl);
528abf3d0ab8047 John Ogness 2021-05-31 103 printk_cpu_unlock(cpu_store, flags);
b58d977432c80ee Alex Thorlton 2013-07-03 104 }
d542aa86de8ad0c Alexander Potapenko 2021-05-26 105 EXPORT_SYMBOL(dump_stack_lvl);
d542aa86de8ad0c Alexander Potapenko 2021-05-26 106

0-DAY CI Kernel Test Service, Intel Corporation

Attachment: .config.gz
Description: application/gzip