Re: [PATCH -next] MIPS: pm-cps: Make '__pcpu_scope_cps_cpu_state' static

From: Thomas Bogendoerfer
Date: Tue Jun 01 2021 - 05:52:13 EST


On Fri, May 28, 2021 at 03:04:37PM +0800, Ruiqi Gong wrote:
> Mark the per-CPU definition of cps_cpu_state as static to fix the following
> sparse tool complain:
>
> arch/mips/kernel/pm-cps.c:66:1: warning:
> symbol '__pcpu_scope_cps_cpu_state' was not declared. Should it be static?

did you compile/link a kernel with this patch ? I doubt that since there
is a refernec to this symbol in arch/mips/kernel/cps-vec.S.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]