Re: [PATCH] drivers: crypto: talitos.c: Replace space with tabs

[Christophe Leroy]

Le 25/05/2021 à 20:15, shubh vk a écrit :
> On Tue, 25 May 2021, 9:45 pm Christophe Leroy, <christophe.leroy@xxxxxxxxxx 
> <mailto:christophe.leroy@xxxxxxxxxx>> wrote:
>
>     Shubhankar Kuranagatti <shubhankarvk@xxxxxxxxx <mailto:shubhankarvk@xxxxxxxxx>> a écrit :
>
>      > Tabs have been used instead of spaces for indentation
>      > This is done to maintain code uniformity(LINDENT).
>
>     Nack.
>
>     The changes done by this patch break linux codying style. For
>     instance, additional lines alignment must match open parenthesis.
>
>     Did you run checkpatch.pl <http://checkpatch.pl/> on your path?
>
>     Yes, I have run checkpatch on my file and it showed no errors or warnings.


Surprisingly, checkpatch on your patch doesn't say anything, but checkpatch on 
drivers/crypto/talitos.c after applying your patch returns the following in addition to the ones 
returned without your patch:

CHECK: Alignment should match open parenthesis
#177: FILE: drivers/crypto/talitos.c:177:
+		setbits32(priv->chan[ch].reg + TALITOS_CCCR_LO,
+				TALITOS_CCCR_LO_IWSE);

CHECK: Alignment should match open parenthesis
#252: FILE: drivers/crypto/talitos.c:252:
+		setbits32(priv->reg_mdeu + TALITOS_EUICR_LO,
+				TALITOS_MDEUICR_LO_ICE);





Christophe