Re: [PATCH 2/6] ARM: xen: Register with kernel restart handler
From: Boris Ostrovsky
Date: Thu Jun 03 2021 - 09:49:52 EST
On 6/3/21 9:38 AM, Lee Jones wrote:
> On Thu, 03 Jun 2021, Guenter Roeck wrote:
>> On Thu, Jun 03, 2021 at 01:43:36PM +0100, Lee Jones wrote:
>>> On Tue, 15 Oct 2019 at 15:52, Thierry Reding <thierry.reding@xxxxxxxxx>
>>>> From: Guenter Roeck <linux@xxxxxxxxxxxx>
>>>> Register with kernel restart handler instead of setting arm_pm_restart
>>>> Select a high priority of 192 to ensure that default restart handlers
>>>> are replaced if Xen is running.
>>>> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>>>> Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>>>> Reviewed-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
>>>> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>>>> Signed-off-by: Thierry Reding <treding@xxxxxxxxxx>
>>>> arch/arm/xen/enlighten.c | 12 ++++++++++--
>>>> 1 file changed, 10 insertions(+), 2 deletions(-)
>>> This patch does appear to be useful.
>>> Is this just being solved in downstream trees at the moment?
>>> It would be nice if we could relinquish people of this burden and get it
>>> into Mainline finally.
>> There must have been half a dozen attempts to send this patch series
>> upstream. I have tried, and others have tried. Each attempt failed with
>> someone else objecting for non-technical reasons (such as "we need more
>> reviews") or no reaction at all, and maintainers just don't pick it up.
> Looking at the *-by tag list above, I think we have enough quality
> reviews to take this forward.
>> So, yes, this patch series can only be found in downstream trees,
>> and it seems pointless to submit it yet again.
> IMHO, it's unfair to burden multiple downstream trees with this purely
> due to poor or nervy maintainership. Functionality as broadly useful
> as this should be merged and maintained in Mainline.
> OOI, who is blocking? As I see it, we have 2 of the key maintainers
> in the *-by list. With those on-board, it's difficult to envisage
> what the problem is.
Stefano (who is ARM Xen maintainer) left Citrix a while ago. He is at sstabellini@xxxxxxxxxx (which I added to the CC line).