Re: [PATCH] nvme: NVME_TCP_OFFLOAD should not default to m

From: Christoph Hellwig
Date: Tue Jun 08 2021 - 08:19:34 EST


On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote:
> The help text for the symbol controlling support for the NVM Express
> over Fabrics TCP offload common layer suggests to not enable this
> support when unsure.
>
> Hence drop the "default m", which actually means "default y" if
> CONFIG_MODULES is not enabled.
>
> Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Err, where did this appear from? This code has not been accepted into
the NVMe tree and is indeed not acceptable in this form.