Re: [PATCH v2 1/2] mm/vmalloc: export __vmalloc_node_range

From: Christoph Hellwig
Date: Thu Jun 10 2021 - 01:25:16 EST


On Wed, Jun 09, 2021 at 07:47:43PM +0200, Christian Borntraeger wrote:
> An alternative would be to provide a vmalloc_no_huge function in generic
> code (similar to vmalloc_32) (or if preferred in s390 base architecture code)
> Something like
>
> void *vmalloc_no_huge(unsigned long size)
> {
> return __vmalloc_node_flags(size, NUMA_NO_NODE,VM_NO_HUGE_VMAP |
> GFP_KERNEL | __GFP_ZERO);
> }
> EXPORT_SYMBOL(vmalloc_no_huge);
>
> or a similar vzalloc variant.

Exactly. Given that this seems to be a weird pecularity of legacy s390
interfaces I'd only export it for 390 for now, although for
documentation purposes I'd probably still keep it in vmalloc.c.